Skip to content

terra: modernize, remove cudatoolkit#539759

Open
ethancedwards8 wants to merge 3 commits into
NixOS:masterfrom
ethancedwards8:cuda-terra
Open

terra: modernize, remove cudatoolkit#539759
ethancedwards8 wants to merge 3 commits into
NixOS:masterfrom
ethancedwards8:cuda-terra

Conversation

@ethancedwards8

@ethancedwards8 ethancedwards8 commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Things done

Related: #232501

@ethancedwards8
terra: remove cudatoolkit
e86e43b 
Signed-off-by: Ethan Carter Edwards <ethan@ethancedwards.com>
@ethancedwards8
terra: enable strictDeps, __structuredAttrs
58394f1 
Signed-off-by: Ethan Carter Edwards <ethan@ethancedwards.com>
@ethancedwards8
terra: modernize slightly
0dd197d 
Signed-off-by: Ethan Carter Edwards <ethan@ethancedwards.com>
@ethancedwards8 ethancedwards8 marked this pull request as ready for review July 9, 2026 00:06
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jul 9, 2026
@ethancedwards8

ethancedwards8 commented Jul 9, 2026

Copy link
Copy Markdown
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 539759
Commit: 0dd197d89733c61a267a2a83c8aa057b87321da3

x86_64-linux

✅ 1 package built:
  • terra

@ethancedwards8

ethancedwards8 commented Jul 9, 2026

Copy link
Copy Markdown
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 539759 --extra-nixpkgs-config '{ allowUnfree = true; cudaSupport = true; }'
Commit: 0dd197d89733c61a267a2a83c8aa057b87321da3

x86_64-linux

✅ 1 package built:
  • terra

elliottslaughter
elliottslaughter approved these changes Jul 9, 2026
View reviewed changes

@elliottslaughter elliottslaughter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me assuming the build passes.

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jb55 jb55 Awaiting requested review from jb55
@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice
@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000
1 more reviewer
@elliottslaughter elliottslaughter elliottslaughter approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ethancedwards8 @elliottslaughter